Exchange `splice_locked` messages (Splicing, Channel Funding)
https://github.com/lightningdevkit/rust-lightning/pull/3741
Host: jbesraa -
Notes
splice_locked is part of the SPLICE COMPLETION step in the splicing process. The splice_locked
message indicates that the splice is completed and the channel can use the new funding transaction.
Questions
- Have you reviewed ldk/3741? If so, is it a Concept ACK, Approach ACK, Tested ACK, or NACK?
- When are
splice_lockedmessages exchanged? - How is the exchange of
splice_lockedmessages tracked? - What happens to a channel’s
FundingScopeaftersplice_lockedmessages are exchanged? - Why is the signature (return value) of
do_chain_eventchanged? - Why is
fn should_emit_channel_ready_eventname changed tofn should_emit_initial_channel_ready_event? - After this PR, LDK will potentially emit
ChannelReadyevent for the same channel more than once. What is the reason for this change? How can we distinguish between the different events?